Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(themes): igx-icon gets overridden multiple themes #15221

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(themes): igx-icon gets overridden multiple themes #15221

merged 3 commits into from
Jan 10, 2025

Conversation

simeonoff
Copy link
Collaborator

Closes #15219

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff linked an issue Jan 9, 2025 that may be closed by this pull request
Bug: Icon size in grid header gets overridden a lot #15219
Closed
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 10, 2025
@simeonoff simeonoff merged commit 620832f into 18.2.x Jan 10, 2025
5 checks passed
@simeonoff simeonoff deleted the simeonoff/fix-15219-18.2.x branch January 10, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova approved these changes

@desig9stein desig9stein Awaiting requested review from desig9stein

Assignees

@dobromirts dobromirts

@SisIvanova SisIvanova

Labels
chip combo filtering 🖼️ icon grid ✨ themes version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Icon size in grid header gets overridden a lot
3 participants
@simeonoff @SisIvanova @dobromirts